Page 1 of 2

[BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sat Dec 04, 2010 1:39 am
by Doug Armand
Easily reproduceable. Start a render and go to the Light Layers Tab.

By default all layer colours are slightly pink - 1.088/0.976/0.957 to be precise. I don't know if that colour is a default but for me I'd prefer the default to be white.

Click on a colour square to load colour picker and change nothing but just click the OK button and colour gets set to white.
If you click cancel the colour gets set to black.
Capture.JPG
Capture2.JPG
Capture3.JPG

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sat Dec 04, 2010 5:31 am
by StompinTom
As far as I know, the pink hue is so that there is no change to the color you specify for your light when it gets internally converted between XYZ (?) and RGB...

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sat Dec 04, 2010 5:56 am
by Doug Armand
StompinTom wrote:As far as I know, the pink hue is so that there is no change to the color you specify for your light when it gets internally converted between XYZ (?) and RGB...
No idea but for me personally I prefer my sunny days to NOT have pink in them :shock:

There is also the bug that if you click OK it converts to white or cancel and it goes black - Cancel should always be cancel in my book

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sat Dec 04, 2010 5:58 am
by pixie
Doug Armand wrote:
StompinTom wrote:As far as I know, the pink hue is so that there is no change to the color you specify for your light when it gets internally converted between XYZ (?) and RGB...
No idea but for me personally I prefer my sunny days to NOT have pink in them :shock:
If you set color to be 6500k and then you have the white point set as D65 it should be white despite looking pink. It's all relative to the white point.

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sat Dec 04, 2010 6:01 am
by Doug Armand
pixie wrote:
Doug Armand wrote:
StompinTom wrote:As far as I know, the pink hue is so that there is no change to the color you specify for your light when it gets internally converted between XYZ (?) and RGB...
No idea but for me personally I prefer my sunny days to NOT have pink in them :shock:
If you set color to be 6500k and then you have the white point set as D65 it should be white despite looking pink. It's all relative to the white point.
Well as a simple end user - if I wanted my haze to be pink I'd like to choose it myself - not have it as a default.This is using a simple sun/sky.

This is one of the problems with coming for help on this forum - all the 'experts' know how to deal with these 'bugs/features' but simple end users like me struggle :wink:

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sat Dec 04, 2010 8:02 am
by CTZn
Hi Doug,

the tone thing was exposed by galinette pretty clearly recently, I am about sure that's something that will be dealt with any soon.

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sat Dec 04, 2010 6:58 pm
by fused
Indigo internally stores the image in XYZ colour space.

Previously light layers were also working in XYZ space, but it has been requested quite often to be able to allow RGB input.

XYZ 1,1,1 is not the same as RGB 1,1,1. The light layers should by default not change the image, so that's why the default light layer colour has to be "pink" (it is what XYZ 1,1,1 converts to).

About the cancel button: yeah, I guess I should fix that :)

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sat Dec 04, 2010 7:11 pm
by Doug Armand
fused wrote:Indigo internally stores the image in XYZ colour space.

Previously light layers were also working in XYZ space, but it has been requested quite often to be able to allow RGB input.

XYZ 1,1,1 is not the same as RGB 1,1,1. The light layers should by default not change the image, so that's why the default light layer colour has to be "pink" (it is what XYZ 1,1,1 converts to).

About the cancel button: yeah, I guess I should fix that :)
Thanks for the info but then the bug is that both Cancel and OK buttons are acting wierd. If you say that 'pink' is correct then just opening the colour picker and clicking OK without changing anything should leave the pink colour. It doesn't it replaces it with white.

The colour picker should open with the already set colour. The current behaviour means there is no way to back out of dialog without changing the already set colours.
It's just plain wrong! :wink:

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sun Dec 05, 2010 12:26 am
by CTZn
Oh okay, so it's not related with the white point, my bad.

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sun Dec 05, 2010 12:59 am
by Doug Armand
CTZn wrote:Oh okay, so it's not related with the white point, my bad.
Well I still think the pink default is wrong but yes the main problem is the wrong behaviour of the colour picker

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sun Dec 05, 2010 2:04 pm
by fused
Hey CTZn,

the whitepoints also chip in somewhere. Have a look here: http://www.brucelindbloom.com/index.htm ... o_RGB.html
and here: http://www.brucelindbloom.com/index.htm ... o_RGB.html

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sun Dec 05, 2010 9:13 pm
by CTZn
Oh, vectors. As far as I can get that gave a few notions, thanks. The second link was on Chromatic Adaptation, right ?

Talking about wich, I'm still wondering wether users really wanted a conversion to RGB or if they wanted to read RGB instead of that puzzling XYZ label. I never understood the need for that change, or didn't know how to appreciate it either. If it's pinking anyhow I'd be fine at home with XYZ back, but I may be loosing the plot as well.

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sun Dec 05, 2010 11:11 pm
by PureSpider
CTZn wrote:Talking about wich, I'm still wondering wether users really wanted a conversion to RGB or if they wanted to read RGB instead of that puzzling XYZ label. I never understood the need for that change, or didn't know how to appreciate it either. If it's pinking anyhow I'd be fine at home with XYZ back, but I may be loosing the plot as well.
Exactly my opinion!
Just replace XYZ by RGB and ignore the fuzz behind it... noone but you coding guys will ever care :lol:

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Sun Dec 05, 2010 11:22 pm
by Doug Armand
Just make it so when using sky/sun the haze by default is blue/white not Pink!!! :evil:

I use a colour calibrated system and it took me ages before I realised what was causing it and how to fix it. It is very annoying and as an end user I don't see what the point of the pink hue is.

Re: [BUG] Indigo GUI color wierdness in Light Layers tab

Posted: Mon Dec 06, 2010 4:15 am
by CTZn
For completeness, here's the thread from Etienne I was referring to:

Color rendering

So it's both recent and aknowledged, for the white point part at least.
Doug Armand wrote:Just make it so when using sky/sun the haze by default is blue/white not Pink!!! :evil:
Aye Sir :D